[PATCH] D154725: [AggressiveInstCombine] Fold strcmp for short string literals

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp:907
+  return false;
+}
+
----------------
kitaisreal wrote:
> goldstein.w.n wrote:
> > should the sqrt patch be split into a preliminary NFC?
> Do you propose to extract most of the changes from `AggressiveInstCombine`, that are not related to `expandStrcmp` in separate patch ?
Yeah, but this has already been approved, so no need to make it a blocker.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154725/new/

https://reviews.llvm.org/D154725