[PATCH] D154812: [Support] Add llvm::xxh3_64bits

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Support/xxhash.cpp:3
 *  xxHash - Fast Hash algorithm
 *  Copyright (C) 2012-2016, Yann Collet
 *
----------------
serge-sans-paille wrote:
> you should probably update the copyright notice to 2021 to reflect upstream https://github.com/Cyan4973/xxHash/blob/dev/LICENSE#L2
Yes, I'll do that. Changing this in the differential would cause clang-format to format all the text below, which is I'd want to avoid. I'll change this when landing...


================
Comment at: llvm/lib/Support/xxhash.cpp:150
+
+#define XXH3_SECRETSIZE_MIN 136
+#define XXH_SECRET_DEFAULT_SIZE 192
----------------
serge-sans-paille wrote:
> could be `constexpr size_t`
Sounds good.

I was to retain the original code style, but since the original code has been mostly rewritten, changing the macros should be fine as well...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154812/new/

https://reviews.llvm.org/D154812