[PATCH] D154782: [NFC] Fix builds on recent GCC with C++20 enabled

Tue Jul 18 13:00:19 PDT 2023

Hahnfeld added a subscriber: tstellar.
Hahnfeld added a comment.

In D154782#4511815 <https://reviews.llvm.org/D154782#4511815>, @alexbatashev wrote:

> In D154782#4511812 <https://reviews.llvm.org/D154782#4511812>, @Hahnfeld wrote:
>
>> Thanks for fixing it! I also discovered it today... I think this is according to the standard: https://eel.is/c++draft/diff.cpp17.class#2 I guess Clang should warn about this; and GCC's error message isn't helpful at all (since version 11 btw)
>
> Totally agree. Did you already submit bugs to both projects?

No, didn't get to it yet. I didn't realize at first that Clang just silently accepts it...

@tstellar also FYI. I know that there are no more point releases planned for 16.0, but the fix in `llvm/lib/Transforms/IPO/AttributorAttributes.cpp` also affects GCC + C++20 builds of `release/16.x`. If there ever is another release of 16.0, this one would be great to include :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154782/new/

https://reviews.llvm.org/D154782