[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/test/Driver/tocdata-mcmodel-large-warning.c:1-8
+// REQUIRES: powerpc-registered-target
+// RUN: %clang -S --target=powerpc-ibm-aix-xcoff -mcmodel=large -mtocdata %s 2>&1 \
+// RUN:   | FileCheck -check-prefix=CHECK32 %s
+// CHECK32: warning: ignoring '-mtocdata' with -mcmodel-large
+
+// RUN: %clang -S --target=powerpc64-ibm-aix-xcoff -mcmodel=large -mtocdata %s 2>&1 \
+// RUN:   | FileCheck -check-prefix=CHECK64 %s
----------------
hubert.reinterpretcast wrote:
> Use `-###` for driver test to:
> 1. Avoid invocation of further components.
> 2. Observe the `-cc1` options being passed.
> 
> Aside from this driver test for the warning, this patch does not seem to have driver tests for validating that the option is passed to `-cc1` if and only if it should be. The missing tests should be added.
> 
> Aside from this driver test for the warning, this patch does not seem to have driver tests for validating that the option is passed to `-cc1` if and only if it should be. The missing tests should be added.

Okay, I see `test/Driver/toc-conf.c` now. It looks like the patch was not generated with a consistent root directory?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153907/new/

https://reviews.llvm.org/D153907