[PATCH] D154725: [AggressiveInstCombine] Fold strcmp for short string literals

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:269
+  });
+}
+
----------------
This should probably have a max iteration cnt?


================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp:907
+  return false;
+}
+
----------------
should the sqrt patch be split into a preliminary NFC?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154725/new/

https://reviews.llvm.org/D154725