[PATCH] D155431: [CMake] Clean up old code for handling MSVC runtime setting the old way

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM, very nice.



================
Comment at: llvm/cmake/modules/ChooseMSVCCRT.cmake:12-13
+# setting different choices for different build configurations (for
+# multi-config generators), but translating multiple differing choices to
+# CMAKE_MSVC_RUNTIME_LIBRARY isn't supported.
 
----------------
Does using generator expressions for this not work, as suggested in https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155431/new/

https://reviews.llvm.org/D155431