[PATCH] D155147: [X86] Add SM3 instructions.

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Headers/sm3intrin.h:28
+/// \code
+/// _mm_sm3msg1_epi32(__m128i __A, __m128i __B, __m128i __C)
+/// \endcode
----------------
Add return type too.


================
Comment at: clang/lib/Headers/sm3intrin.h:85
+/// \code
+/// _mm_sm3msg2_epi32(__m128i __A, __m128i __B, __m128i __C)
+/// \endcode
----------------
ditto.


================
Comment at: clang/lib/Headers/sm3intrin.h:148
+/// \code
+/// _mm_sm3rnds2_epi32(__m128i __A, __m128i __B, __m128i __C, const int imm8)
+/// \endcode
----------------
ditto.


================
Comment at: clang/lib/Headers/sm3intrin.h:230
+/// \endcode
+#define _mm_sm3rnds2_epi32(A, B, C, D)                                         \
+  (__m128i) __builtin_ia32_vsm3rnds2((__v4su)A, (__v4su)B, (__v4su)C, (int)D)
----------------
Missing `__` for variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155147/new/

https://reviews.llvm.org/D155147