[PATCH] D155148: [X86] Add SM4 instructions.

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 07:09:36 PDT 2023


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

In D155148#4510472 <https://reviews.llvm.org/D155148#4510472>, @RKSimon wrote:

> @pengfei Are you happy with the intrinsics doxygen descriptions?

LGTM except for one comment.



================
Comment at: clang/lib/Headers/sm4intrin.h:23
+/// \code
+/// _mm_sm4key4_epi32(__m128i __A, __m128i __B)
+/// \endcode
----------------
Missing return type here. The same for below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155148/new/

https://reviews.llvm.org/D155148



More information about the llvm-commits mailing list