[PATCH] D155441: [ADT] Remove SFINAE constraint from llvm::iterator_range ctor for gcc-7

Tue Jul 18 04:15:30 PDT 2023

crobeck added a comment.

In D155441#4509069 <https://reviews.llvm.org/D155441#4509069>, @steakhal wrote:

> In D155441#4508400 <https://reviews.llvm.org/D155441#4508400>, @crobeck wrote:
>
>> FWIW, the lit checks were failing for me with with GCC 8.3 so that GCC version check may need to be more inclusive.
>
> Don't start this 😅 
> At this point, I'm very much out of my comfort zone.
> I had to install custom PPA only to get gcc-7 and gcc-8 on my system, as those are no longer available officially.
> I managed to get 7.5.0 and 8.4.0, so I could fix this. However, to get 8.3, I'd assume I need to compile gcc only for this.
> And I'm not sure if we should expect all minor versions of a compiler. To me, it makes more sense to support only the latest revision of a major compiler version.
>
> I intentionally, waited for the Harbormaster to see breakages. Also, after I landed the patch, I waited a couple of days until I pushed some other changes to build on top of this feature to make sure we didn't need to revert many changes if something breaks.
> IMO if we would really care about these compilers, we should have them in BuildKite.

Oh, sure. Sorry, what I was trying, unsuccessfully apparently, to get across was that it built fine but then failed during the lit tests. Not about the actual GCC version.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155441/new/

https://reviews.llvm.org/D155441