[PATCH] D153808: [CodeGen] Add support for integers using SVE2 in ComplexDeinterleaving passDepends on D153355

mgabka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 01:16:49 PDT 2023


mgabka accepted this revision.
mgabka added a comment.
This revision is now accepted and ready to land.

Probably worth to polish a bit commit message, but apart from that it LGTM.
Thanks for addressing my comments.



================
Comment at: llvm/test/CodeGen/AArch64/complex-deinterleaving-i16-mul-scalable.ll:6
+
+; Expected to not transform
+define <vscale x 4 x i16> @complex_mul_v4i16(<vscale x 4 x i16> %a, <vscale x 4 x i16> %b) {
----------------
Could you add a comment explaining why? (I thought that you are going to apply my comment to the previous test to all tests).


================
Comment at: llvm/test/CodeGen/AArch64/complex-deinterleaving-i8-add-scalable.ll:7
+
+; Expected to not transform
+define <vscale x 8 x i8> @complex_add_v8i8(<vscale x 8 x i8> %a, <vscale x 8 x i8> %b) {
----------------
please add a comment explaining why


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153808/new/

https://reviews.llvm.org/D153808



More information about the llvm-commits mailing list