[PATCH] D153638: [CodeGenPrepare][NFC] Update the dominator tree instead of rebuilding it

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 01:03:34 PDT 2023


dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:432
+  DominatorTree &getDT() {
+    if (DTU->hasPendingUpdates())
+      DTU->flush();
----------------
I think DTU->getDomTree() will already do this.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:8342
           break;
-        } else {
-          return true;
-        }
+         return true;
       }
----------------
Formatting?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153638/new/

https://reviews.llvm.org/D153638



More information about the llvm-commits mailing list