[PATCH] D154053: [CGP] Refactor optimizeSelectInst (NFC)

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

This looks good as far as I can tell. The formatting needs updating a little in places.



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7004
+  for (SelectInst *SI : ASI) {
+    if (Value  *V = SI->getTrueValue(); sinkSelectOperand(TTI, V))
+      TrueInstrs.push_back(cast<Instruction>(V));
----------------
Formatting.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7030
+    TrueBranch =
+        cast<BranchInst>(SplitBlockAndInsertIfThen(CondFr, &*SplitPt, false, nullptr, nullptr, LI));
+    TrueBlock = TrueBranch->getParent();
----------------
Formatting.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154053/new/

https://reviews.llvm.org/D154053