[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv

Vlad Serebrennikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 20:02:24 PDT 2023


Endill added a comment.

In D154984#4508361 <https://reviews.llvm.org/D154984#4508361>, @jdenny wrote:

> 1. Keep "Script:".  To address the redundancy problem that motivated this patch, disable "Script:" by default when just given -a or -v, and add some new command-line option to enable it (or maybe recycle -vv).

I can easily imagine people being confused that what was `-vv` is now `-v`, but `-vv` lives on with new semantics.

> To address the PYTHON line problem that motivated this patch, "Script:" would not include RUN lines beyond the first PYTHON line.

This doesn't feel intuitive for users as well. More like an implementation detail leaking to user interface, which users will have to learn about.

Because of that, I'd discourage going with option 1 even as stopgap until landing another option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154984/new/

https://reviews.llvm.org/D154984



More information about the llvm-commits mailing list