[PATCH] D155441: [ADT] Remove SFINAE constraint from llvm::iterator_range ctor for gcc-7

Immolo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 19:02:19 PDT 2023


immolo added a comment.

In D155441#4508400 <https://reviews.llvm.org/D155441#4508400>, @crobeck wrote:

> In D155441#4507897 <https://reviews.llvm.org/D155441#4507897>, @steakhal wrote:
>
>> In D155441#4507877 <https://reviews.llvm.org/D155441#4507877>, @MaskRay wrote:
>>
>>>> Allegedly, GCC-8 and above builds just fine.
>>>
>>> It would be nice to test this:)
>>
>> I'll check that tomorrow.
>
> FWIW, the lit checks were failing for me with with GCC 8.3 so that GCC version check may need to be more inclusive.

For some added information I used gcc-8.5 for this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155441/new/

https://reviews.llvm.org/D155441



More information about the llvm-commits mailing list