[PATCH] D154102: Headers for basic blocks in control flow dot graphs

[Kirill Naumov via Phabricator via llvm-commits]

knaumov added inline comments.


================
Comment at: llvm/include/llvm/Analysis/CFGPrinter.h:149
   raw_string_ostream OS(Str);
-
-  if (Node->getName().empty()) {
-    Node->printAsOperand(OS, false);
-    OS << ':';
-  }
-
   HandleBasicBlock(OS, *Node);
   std::string OutStr = OS.str();
----------------
Haven't you changed the logic of the OS argument here? It seems that now it is always empty.


================
Comment at: llvm/include/llvm/Analysis/CFGPrinter.h:154
 
+  // Preprend BB name if the name is not set and the code does not start
+  // with BB number label
----------------
Nit: Typo in "Prepend"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154102/new/

https://reviews.llvm.org/D154102