[PATCH] D154858: [AMDGPU] Add llvm.amdgcn.wave.reduce.umin/umax Intrinsic.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:982
 
+  llvm.amdgcn.reduce.umin/umax               Performs the reduction across the wavefront on a given
+                                             unsigned value i.e. first operand. Intrinsic takes hint
----------------
Missing wave from the name. Also, probably should spell out each one individually rather than putting a / in the names


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:4079
+  ScanOptions ScanStrategy =
+      ScanStratgyImm == 0 ? ScanOptions::Iterative : ScanOptions::DPP;
+  if (ScanStrategy == ScanOptions::DPP) {
----------------
See my above comment, 0 should be auto 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154858/new/

https://reviews.llvm.org/D154858