[llvm] 53abf2d - Revert "[llvm-reduce] Reduce function calling convention"

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 16:11:06 PDT 2023


Author: Arthur Eubanks
Date: 2023-07-17T16:10:55-07:00
New Revision: 53abf2d56f8a78ef86c56e7f025a568b3b6a2337

URL: https://github.com/llvm/llvm-project/commit/53abf2d56f8a78ef86c56e7f025a568b3b6a2337
DIFF: https://github.com/llvm/llvm-project/commit/53abf2d56f8a78ef86c56e7f025a568b3b6a2337.diff

LOG: Revert "[llvm-reduce] Reduce function calling convention"

This reverts commit 702a4d89b413dfcd6619007de1056a48b60f367a.

Can break calling convention restrictions.

Added: 
    

Modified: 
    llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp

Removed: 
    llvm/test/tools/llvm-reduce/reduce-calling-convention.ll


################################################################################
diff  --git a/llvm/test/tools/llvm-reduce/reduce-calling-convention.ll b/llvm/test/tools/llvm-reduce/reduce-calling-convention.ll
deleted file mode 100644
index 165a2cd6795475..00000000000000
--- a/llvm/test/tools/llvm-reduce/reduce-calling-convention.ll
+++ /dev/null
@@ -1,18 +0,0 @@
-; Test that llvm-reduce can remove function calling conventions.
-;
-; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=function-data --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
-; RUN: FileCheck --check-prefix=CHECK-FINAL --implicit-check-not=fastcc %s < %t
-
-; CHECK-INTERESTINGNESS: declare
-; CHECK-INTERESTINGNESS-SAME: void @f
-
-; CHECK-FINAL: declare void @f()
-
-declare void @f()
-
-; CHECK-INTERESTINGNESS: declare
-; CHECK-INTERESTINGNESS-SAME: void @g
-
-; CHECK-FINAL: declare void @g()
-
-declare fastcc void @g()

diff  --git a/llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp b/llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp
index 16ab3571588e53..21875ba00cf8b2 100644
--- a/llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp
+++ b/llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp
@@ -54,9 +54,6 @@ static void reduceFunctionData(Oracle &O, ReducerWorkItem &WorkItem) {
 
     if (F.hasPrologueData() && !O.shouldKeep())
       F.setPrologueData(nullptr);
-
-    if (F.getCallingConv() != CallingConv::C && !O.shouldKeep())
-      F.setCallingConv(CallingConv::C);
   }
 }
 


        


More information about the llvm-commits mailing list