[PATCH] D155143: [DX] Fix PSV resource serialization

Joshua Batista via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 16:09:46 PDT 2023


bob80905 accepted this revision.
bob80905 added a comment.

LGTM



================
Comment at: llvm/include/llvm/Object/DXContainer.h:95-96
 
       bool operator==(const iterator I) { return I.Current == Current; }
       bool operator!=(const iterator I) { return !(*this == I); }
     };
----------------
Just curious whether this should be revisited, or why these operators aren't defined in terms of the opposite of the other.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155143/new/

https://reviews.llvm.org/D155143



More information about the llvm-commits mailing list