[PATCH] D155119: [sancov] Switch to OptTable from llvm::cl

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a subscriber: thakis.
leonardchan added inline comments.


================
Comment at: llvm/tools/sancov/Opts.td:50
+def : Flag<["-"], "skip-dead-files=0">, Alias<no_skipDeadFiles>, HelpText<"Alias for --no-skip-dead-files">;
+def : Flag<["-"], "use_default_ignore_list=0">, Alias<no_useDefaultIgnoreList>, HelpText<"Alias for --no-use_default_ignore_list">;
+
----------------
`use_default_ignorelist` to match the original flag name


================
Comment at: llvm/utils/gn/secondary/llvm/tools/sancov/BUILD.gn:1
+import("//llvm/utils/TableGen/tablegen.gni")
+
----------------
I believe the gn sub-build is also [peripheral tier](https://llvm.org/docs/SupportPolicy.html#peripheral-tier) and actually updated by a script maintained by @thakis, so BUILD.gn changes shouldn't be included here.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:4675
 
+gentbl(
+    name = "SancovOptsTableGen",
----------------
I believe the bazel build is part of the [peripheral tier](https://llvm.org/docs/SupportPolicy.html#peripheral-tier) and maintained by someone else who would make the necessary bazel changes. You only need to update the cmake files. Alternatively, if you want to land this also, I think we'd need to find a bazel reviewer to make sure this is correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155119/new/

https://reviews.llvm.org/D155119