[PATCH] D154987: [lit] Implement PYTHON directive and config.prologue

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 15:32:51 PDT 2023


ldionne added a comment.

In D154987#4501125 <https://reviews.llvm.org/D154987#4501125>, @jdenny wrote:

> @ldionne: It looks like this patch has revealed an existing bug in `libcxx/test/libcxx/selftest/sh.cpp/empty.sh.cpp`, but I'm not sure how best to handle it.  Can you help?
>
> [...]
>
> I tried to fix the test so it exercises what it was meant to: no RUN lines.  To do so, I removed the `:` after `RUN`.  Both //before and after// this patch, that produces an unresolved test status, and again that seems like the right lit behavior for a malformed test.  However, again, that means the test suite now fails.  How would you like to handle that?

Thanks for the heads up and the detailed explanation. It looks like there's no reliable way to test what I was trying to test, and that test isn't *that* important anyway. I'll remove it since it was broken in the first place, so just rebase your patch. Sorry for the trouble.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154987/new/

https://reviews.llvm.org/D154987



More information about the llvm-commits mailing list