[PATCH] D153963: [InstCombine] Fold binop of select and cast of select condition

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 14:22:13 PDT 2023


goldstein.w.n added a comment.

In D153963#4507798 <https://reviews.llvm.org/D153963#4507798>, @antoniofrighetto wrote:

> @goldstein.w.n, thank you, I think it should work out properly now.

We don't see any test changes as a result of the impl.
You need to do the following:

1. Update the tests in the test patch with LLVM compiled WITHOUT your change.
2. Update the tests in this patch with LLVM compiled WITH your change.

That way we can see exact what your change actually changes..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153963/new/

https://reviews.llvm.org/D153963



More information about the llvm-commits mailing list