[PATCH] D151335: [AIX][TLS] Generate .extern and .ref references to __tls_get_addr for local-exec accesses.

Mon Jul 17 13:54:05 PDT 2023

DiggerLin added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:629
+    if (SMC == XCOFF::XMC_DS)
+      SymName = "__tls_get_addr";
+  }
----------------
change to

```
SymName = SMC == XCOFF::XMC_DS  ? "__tls_get_addr" : .__tls_get_addr ;
```

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2878
+    MCSymbol *TlsGetAddrDescriptor =
+        createMCSymbolForTlsGetAddr(OutContext, PPC::LDtoc, XCOFF::XMC_DS);
+
----------------
I know that any value of non PPC::GETtlsTpointer32AIX is OK here
but why it is PPC::LDtoc here ? can we use "PPC::GETtlsADDR" here ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151335/new/

https://reviews.llvm.org/D151335