[PATCH] D146778: [lld] Preliminary fat-lto-object support

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Options.td:648
+defm fat_lto_objects: BB<"fat-lto-objects",
+    "Use the embedded bitcode in the .llvm.lto section of the relocatable object file for LTO",
+    "Use the .text section in the relocatable object file (default)">;
----------------
This can reuse the manpage description.

For example, the ".text" part in "Use the .text section in the relocatable object file (default)" is not accurate.


================
Comment at: lld/test/ELF/fatlto/fatlto.invalid.s:4
+
+# CHECK: Invalid bitcode signature
+
----------------
Add `error:` is present in the diagnostic.


================
Comment at: lld/test/ELF/fatlto/fatlto.invalid.s:10
+        .size   .Lllvm.embedded.object, 12
+
----------------
delete trailing blank line


================
Comment at: lld/test/ELF/fatlto/fatlto.test:106
+
+^0 = module: (path: "main-LTO.bc", hash: (0, 0, 0, 0, 0))
+^1 = gv: (name: "_start") ; guid = 12157170054180749580
----------------
We should not test module summary index. They are unstable and may change, and cause hassle for future LTO changes. This part should be generated by opt --module-summary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146778/new/

https://reviews.llvm.org/D146778