[PATCH] D152677: [InstCombine] If there is a known-bit transform is_pow2 check to just check for any other bits

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 12:34:14 PDT 2023


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3626
                                                              IntrinsicInst *II,
                                                              const APInt &C) {
   if (Cmp.isEquality())
----------------
goldstein.w.n wrote:
> nikic wrote:
> > If you rebase, there should be a switch here where you can handle both equality and non-equality comparisons in one place.
> Hmm? Don't see any change to the function signiture on master.
I'm referring to the switch directly above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152677/new/

https://reviews.llvm.org/D152677



More information about the llvm-commits mailing list