[PATCH] D155464: [llvm-objdump] Use BBEntry::BBID to represent basic block numbers.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 12:06:11 PDT 2023


mtrofin accepted this revision.
mtrofin added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-bbaddrmap-disassemble-symbolize-operands.yaml:172
         BBEntries:
-          - AddressOffset: 0x0
+          - ID:            4
+            AddressOffset: 0x0
----------------
Nit: maybe use a BB ID-ing that's more "random", like 3-1-2-4 maybe, so something that could be less likely attributable to a reverse engineering of the ID.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155464/new/

https://reviews.llvm.org/D155464



More information about the llvm-commits mailing list