[PATCH] D155252: [PseudoProbe] Remove unnecessary asserts about non-zero discriminator.

Mon Jul 17 09:28:38 PDT 2023

hoy added a comment.

In D155252#4502753 <https://reviews.llvm.org/D155252#4502753>, @wenlei wrote:

> In D155252#4501305 <https://reviews.llvm.org/D155252#4501305>, @hoy wrote:
>
>> In D155252#4499632 <https://reviews.llvm.org/D155252#4499632>, @wenlei wrote:
>>
>>> In general if the effort to make sure probe has zero discriminator is too much, it makes sense to just rely on discriminator clean up instead during FS discriminator assignment for probes. I'm curious though what exposed this case? IIRC, we didn't hit this assert for a while now.
>>
>> Yeah, it was good for a while until incrPGO was on. I suspect incrPGO opened more opportunity for optimizations and exposed this issue.
>
> Since we already did many fixes, if it's just one or two more fixes, do you think we could try to keep it?

There doesn't seem to be a very clean fix for this issue. The debug loc merge API (`getMergedLocation`) takes two DebugLoc params, so to tell if they are from two probes we would need to go above a level but there are quite a few places doing code merge.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155252/new/

https://reviews.llvm.org/D155252