[PATCH] D155391: [RISCV] Use RISCVISD::CZERO_EQZ/CZERO_NEZ for XVentanaCondOps.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 08:15:23 PDT 2023


asb added a comment.

I was going to leave moving over the similar condops until we'd resolve questions about the extra combines, given these extensions aren't "experimental" like zicond is. But this looks fine to me - thanks.

Regarding the suggestion to rename the RISCVISD::CZERO_* nodes - I'm not sure there's much value in this, as the zicond naming is the "definitive" one and it's hard to see much use of xventacondops going forwards now there's a standard extension.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155391/new/

https://reviews.llvm.org/D155391



More information about the llvm-commits mailing list