[PATCH] D153967: [lit] Remove the --no-indirectly-run-check option

Mon Jul 17 06:53:10 PDT 2023

ldionne marked an inline comment as done.
ldionne added inline comments.

================
Comment at: llvm/utils/lit/lit/discovery.py:170-171
+        # tests.
+        tests = [Test.Test(ts, path_in_suite, lc)] if lc.test_format is None or lc.standalone_tests else \
                 lc.test_format.getTestsForPath(ts, path_in_suite, litConfig, lc)

----------------
jdenny wrote:
> If I understand correctly, if a directory is in standalone mode because tests are always run individually, it is not possible to use a test format that overrides getTestsForPaths in order to generate multiple tests from each of those individual tests.  Is that correct?  I'm not saying that's problematic.  I just want to be sure I understand.
Yes, that is correct. TBH I am also skeptical about the usefulness of "standalone" tests in the first place, it seems like they were introduced as a clutch for people not wanting to have appropriate suffixes and lit excludes in the first place.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153967/new/

https://reviews.llvm.org/D153967