[PATCH] D155214: Preserve important metadata in JumpThreadingPass::unfoldSelectInstr

Mon Jul 17 06:25:25 PDT 2023

mmendell abandoned this revision.
mmendell added a comment.

I see that this is not needed any more.  No idea why my version of LLVM has this problem....

================
Comment at: llvm/test/Transforms/JumpThreading/preserve-select-unfold.ll:4
+target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024"
+target triple = "spir64-unknown-unknown-intelfpga"
+
----------------
nikic wrote:
> Use update_test_checks.py with --check-globals, remove data layout and triple.
Actually, this was the wrong test case :-).  It was supposed to be https://llvm.godbolt.org/z/GKzGzEr7o.  On the other hand, it seems to be working as well.  I was basing my change on an older LLVM.  I am trying to bring it up to trunk.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155214/new/

https://reviews.llvm.org/D155214