[PATCH] D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits
Phoebe Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 17 06:13:58 PDT 2023
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
X86 changes look good to me expect one nit.
================
Comment at: llvm/test/CodeGen/X86/2009-05-30-ISelBug.ll:12
+; CHECK-NEXT: # kill: def $edx killed $edx def $rdx
+; CHECK-NEXT: shrl $8, %edx
; CHECK-NEXT: addl $4, %r10d
----------------
This results in scale to be 4, which may do bad for performance?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146121/new/
https://reviews.llvm.org/D146121
More information about the llvm-commits
mailing list