[PATCH] D155436: InstSimplify: Handle basic folds for frexp

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added inline comments.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:3318
+  Constant *Result1 = FrexpMant.isFinite() ? ConstantInt::get(IntTy, FrexpExp)
+                                           : UndefValue::get(IntTy);
+
----------------
I suggest we use 0 here to avoid adding another use of undef. Also, it's unclear if undef is ok or if we would need `freeze poison`.

The rest, LGTM!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155436/new/

https://reviews.llvm.org/D155436