[PATCH] D155068: [Remarks] Introduce `llvm-remark-diff` tool.

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 03:00:05 PDT 2023


thegameg requested changes to this revision.
thegameg added a comment.
This revision now requires changes to proceed.

Few things:

1. Can we make the default mode to output something like opt-diff (`llvm/tools/opt-viewer/opt-diff.py`)? Then you can have a JSON mode.
2. Can this be a `cl::SubCommand` of `llvm-remarkutil`? It would be great if `llvm-remark-size-diff` was too.



================
Comment at: llvm/include/llvm/Remarks/Remark.h:134
 
-private:
   /// In order to avoid unwanted copies, "delete" the copy constructor.
----------------
Why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155068/new/

https://reviews.llvm.org/D155068



More information about the llvm-commits mailing list