[PATCH] D155377: [SanitizerCoverage] Add fallback DebugLocation for instrumented calls

Jakob via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 02:48:44 PDT 2023


jkl added inline comments.


================
Comment at: llvm/test/Instrumentation/SanitizerCoverage/missing_dbg.ll:5
+
+define i32 @with_dbg(ptr %a, ptr %b) sanitize_address !dbg !3 {
+entry:
----------------
melver wrote:
> melver wrote:
> > jkl wrote:
> > > melver wrote:
> > > > Is sanitize_address needed for this test?
> > > oh, no. It's just a leftover from copying the other test. LKM if I should send an update or if you just want to fix it when committing
> > I assume it's trivial to fix, so just fixing it before committing is fine.
> Oh, do you have commit access, or should I commit it?
No I don't, so you can just go ahead with it. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155377/new/

https://reviews.llvm.org/D155377



More information about the llvm-commits mailing list