[PATCH] D155415: [AIX][TLS] Account for local-exec accesses in XCOFFObjectWriter

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-tls-le-xcoff-reloc.ll:183
+; SYM:     Index: 35
+; SYM-NEXT:     Name: IThreadLocalVarUninit
+; SYM-NEXT:     Value (RelocatableAddress): 0x8
----------------
Copy/paste error?


================
Comment at: llvm/test/CodeGen/PowerPC/aix-tls-le-xcoff-reloc.ll:255-256
+; DIS:      00000000000000a0 (idx: 21) IThreadLocalVarUninit[TC]:
+; DIS-NEXT:       a0: 00 00 00 00
+; DIS-NEXT: 00000000000000a0:  R_TLS_LE     (idx: 33) IThreadLocalVarUninit[UL]
+; DIS:      00000000000000a8 (idx: 23) ThreadLocalVarInit[TC]:
----------------
Missing the interesting 4 bytes of the encoded value.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-tls-le-xcoff-reloc.ll:258-259
+; DIS:      00000000000000a8 (idx: 23) ThreadLocalVarInit[TC]:
+; DIS-NEXT:       a8: 00 00 00 00
+; DIS-NEXT: 00000000000000a8:  R_TLS_LE     (idx: 31) ThreadLocalVarInit
+; DIS:      00000000000000b0 (idx: 25) VarInit[TC]:
----------------
Same comment.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-tls-le-xcoff-reloc.ll:261-262
+; DIS:      00000000000000b0 (idx: 25) VarInit[TC]:
+; DIS-NEXT:       b0: 00 00 00 00
+; DIS-NEXT: 00000000000000b0:  R_POS        (idx: 11) VarInit
+; DIS:      00000000000000b8 (idx: 27) IThreadLocalVarUninit2[TC]:
----------------
To be consistent, same comment.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-tls-le-xcoff-reloc.ll:264-265
+; DIS:      00000000000000b8 (idx: 27) IThreadLocalVarUninit2[TC]:
+; DIS-NEXT:       b8: 00 00 00 00
+; DIS-NEXT: 00000000000000b8:  R_TLS_LE     (idx: 35) IThreadLocalVarUninit2[UL]
 
----------------
Same comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155415/new/

https://reviews.llvm.org/D155415