[PATCH] D138135: [lld][ELF] Support LoongArch

Sun Jul 16 21:08:10 PDT 2023

xen0n added inline comments.

================
Comment at: lld/ELF/Arch/LoongArch.cpp:111
+  //
+  // With dest=0x900'10000'abcde'f00 and pc=0x800'20345'ba987'654, we want:
+  //
----------------
MaskRay wrote:
> This example doesn't trigger the interesting case `signLo12 != signHi20`. We need a different example.
Ah, I copied a wrong fixture from my experiments, sorry for that. I've made new examples to cover both directions of adjustment.

================
Comment at: lld/test/ELF/loongarch-branch-b16.s:23
+# ERROR-RANGE: relocation R_LARCH_B16 out of range: 131072 is not in [-131072, 131071]; references 'foo'
+# ERROR-RANGE: relocation R_LARCH_B16 out of range: -131076 is not in [-131072, 131071]; references 'bar'
+
----------------
MaskRay wrote:
> Add `-NEXT` whenever applicable.
Okay. Here it's not applicable though, as the actual diagnostics have `>>> defined in --defsym:1` and an empty line in between, which is irrelevant to our intended assertion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138135/new/

https://reviews.llvm.org/D138135