[PATCH] D155391: [RISCV] Use RISCVISD::CZERO_EQZ/CZERO_NEZ for XVentanaCondOps.

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 16 20:39:04 PDT 2023


wangpc added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:365
+  // defined in Zicond or XVentanaCondOps.
+  CZERO_EQZ, // vt.maskc for XVentanaCondOps.
+  CZERO_NEZ, // vt.maskcn for XVentanaCondOps.
----------------
wangpc wrote:
> What about renaming these two nodes to `SELECT_EQZ/NEZ`  with another NFC patch?
`SELECT_ZERO_EQZ/NEZ` would be better according to their semantics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155391/new/

https://reviews.llvm.org/D155391



More information about the llvm-commits mailing list