[PATCH] D155142: Add PBNDKB instruction.

Freddy, Ye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 16 18:47:27 PDT 2023


FreddyYe added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrSystem.td:432
 def RDMSR : I<0x32, RawFrm, (outs), (ins), "rdmsr", []>, TB;
-
+let Defs = [RAX, EFLAGS], Uses = [RBX, RCX], Predicates = [In64BitMode] in
+def PBNDKB : I<0x01, MRM_C7, (outs), (ins), "pbndkb", []>, PS;
----------------
skan wrote:
> I don't know if it would make a difference, but according to SPEC, should we change `RAX` to `EAX`?
This instruction is 64 bit only valid. So I think it's a typo in SPEC's 'Description' section. And I notice that in 'Operation' section, it used RAX instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155142/new/

https://reviews.llvm.org/D155142



More information about the llvm-commits mailing list