[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

[MyDeveloperDay via Phabricator via llvm-commits]

MyDeveloperDay added a comment.

I don't have a problem with this, but I'm not an ObjC person so I can't really review from the validity of what its changing. If @owenpan and @HazardyKnusperkeks don't have an problem with this then I don't either as it likely won't impact most C++ users.



================
Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:10
 /// \file
-/// This file implements LeftRightQualifierAlignmentFixer, a TokenAnalyzer that
+/// This file implements QualifierAlignmentFixer, a TokenAnalyzer that
 /// enforces either left or right const depending on the style.
----------------
This is an unrelated change, it wrong and that was probably my fault, we should do this as a NFC


================
Comment at: llvm/utils/gn/secondary/clang/lib/Format/BUILD.gn:23
     "NamespaceEndCommentsFixer.cpp",
+    "ObjCPropertyAttributeOrderFixer.cpp",
     "QualifierAlignmentFixer.cpp",
----------------
I never change these file either I think there is a bot or something that does this.


================
Comment at: llvm/utils/gn/secondary/clang/unittests/Format/BUILD.gn:39
     "NamespaceEndCommentsFixerTest.cpp",
+    "ObjCPropertyAttributeOrderFixerTest.cpp",
     "QualifierFixerTest.cpp",
----------------
I never change these file either I think there is a bot or something that does this.


================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1360
         "lib/Format/Macros.h",
+        "lib/Format/ObjCPropertyAttributeOrderFixer.h",
         "lib/Format/QualifierAlignmentFixer.h",
----------------
I never change these files I don't think we need to?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150083/new/

https://reviews.llvm.org/D150083