[PATCH] D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization
Alan Phipps via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 15 15:45:55 PDT 2023
alanphipps marked 27 inline comments as done.
alanphipps added inline comments.
================
Comment at: llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h:495
+ std::ostringstream ss;
+ // Print Individual Conditions
+ ss << " " << TestVector + 1 << " { ";
----------------
paquette wrote:
> Maybe there should be a function called `printConditions`?
The function is really constructing a string. I'm going to leave the function intact but it makes sense that the comments shouldn't say "print" when that's not really what it's doing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138847/new/
https://reviews.llvm.org/D138847
More information about the llvm-commits
mailing list