[PATCH] D154294: [Windows SEH]: Do not fold branches for MSVC TableSEH function

Sat Jul 15 10:30:53 PDT 2023

efriedma added a comment.

In D154294#4503150 <https://reviews.llvm.org/D154294#4503150>, @pengfei wrote:

>> Can you look into adding EH edges to the relevant blocks?
>
> Yeah, a possible solution is the fallthrough BB to inherit the successors of the BB that merging to it. But I'm worrying it affects non SEH scenarios as well. We have already used EHScopeMembership/SameEHScope to calculate for them. I think the best solution is to take SEH state number into account. But I haven't figure out the mechanism of EHScopeMembership and how to do it for SEH. So in this patch, I just skip this transform for MSVC_TableSEH.

I was thinking you'd add the edges computed by SEH numbering during isel.  I agree it's not a good idea to try to inherit the edges.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154294/new/

https://reviews.llvm.org/D154294