[PATCH] D141189: [Mips] Set setMaxAtomicSizeInBitsSupported

Sat Jul 15 02:07:02 PDT 2023

wzssyqa added a comment.

In D141189#4502727 <https://reviews.llvm.org/D141189#4502727>, @efriedma wrote:

> LGTM.  (I was sort of hoping for someone with Mips expertise to show up to approve this, but lacking that, I don't see any issues here.)

As I said before. I don't think this patch is preferable.
As MIPS II has LDC1/SDC1, which make it possible to has 64bit aotmic load/store.

This patch will make all MIPS32 performance regression.

  if (Subtarget.isGP64bit())
    setMaxAtomicSizeInBitsSupported(64);
  else
    setMaxAtomicSizeInBitsSupported(32);

is only suitable for softfloat target not hardfloat target.

We need a more complicated login here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141189/new/

https://reviews.llvm.org/D141189