[PATCH] D155329: [TableGen][CodeEmitterGen] Add support for querying operand bit offsets

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/utils/TableGen/CodeEmitterGen.cpp:216
+      BitOffsetCase += "        return " +
+                       utostr(BI->getNumBits() - beginInstBit - 1) + ";\n";
+      BitOffsetCaseEmitted = true;
----------------
If I'm reading this right, this is the offset from the MSB of the encoding to the MSB of the field? Which works for SystemZ because the encoding bytes are emitted in big endian, but would not be useful for a little endian target?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155329/new/

https://reviews.llvm.org/D155329