[PATCH] D155274: [GIsel][AArch64] extend legalization of G_INSERT_VECTOR_ELT

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 18:26:34 PDT 2023


Allen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:702
   getActionDefinitionsBuilder(G_INSERT_VECTOR_ELT)
-      .legalIf(typeInSet(0, {v16s8, v8s8, v8s16, v4s16, v4s32, v2s32, v2s64}));
+      .legalIf(typeInSet(0, {v16s8, v8s8, v8s16, v2s16, v4s16,
+                             v4s32, v2s32, v2s64}));
----------------
Thanks for helping to fix, would it make sense to add some other types, such as v2s8 ?
https://gcc.godbolt.org/z/azrjv64E8


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155274/new/

https://reviews.llvm.org/D155274



More information about the llvm-commits mailing list