[PATCH] D155345: [ConstantHoisting] use struct rather than tuple for adjustments

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 15:37:31 PDT 2023


nickdesaulniers created this revision.
Herald added a subscriber: hiraditya.
Herald added a reviewer: ributzka.
Herald added a project: All.
nickdesaulniers requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We pack this info in a tuple just to spread it back out for a function
call. Spreads in C++ are awkward.  If I want to add an additional
element to the tuple, I need to add more calls to std::get<> later. Just
use a struct.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155345

Files:
  llvm/include/llvm/Transforms/Scalar/ConstantHoisting.h
  llvm/lib/Transforms/Scalar/ConstantHoisting.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155345.540579.patch
Type: text/x-patch
Size: 8498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230714/fa7fa1dd/attachment-0001.bin>


More information about the llvm-commits mailing list