[PATCH] D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns

[Konstantina Mitropoulou via Phabricator via llvm-commits]

kmitropoulou added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6059
+        CCR != ISD::SETNE) {
+      if (CCL != ISD::getSetCCSwappedOperands(CCR)) {
+        if (LHS0 == RHS0) {
----------------
craig.topper wrote:
> Is this the same as CCL == CCR?
You are right! This condition should be CCL == CCR and the condition at line 6071 should be CCL == ISD::getSetCCSwappedOperands(CCR) .


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6098
+
+        if (NewOpcode) {
+          SDValue MinMaxValue =
----------------
craig.topper wrote:
> Can NewOpcode ever be unassigned here?
You are right! It is not needed here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153502/new/

https://reviews.llvm.org/D153502