[PATCH] D155323: [CMake] Don't exclude llvm-debuginfod if httplib isn't available

Daniel Thornburgh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 11:54:31 PDT 2023


mysterymath added a comment.

Could we include a similarly descriptive error message in llvm-debuginfod as in llvm-mt as part of this? As is, this will produce a binary with undefined behavior, as it will hit a llvm_unreachable when attempting to use HTTPServer. Seems like HTTPServer is the right place for this; it should probably report_fatal_error instead of llvm_unreachable, and mention the specific library dep.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155323/new/

https://reviews.llvm.org/D155323



More information about the llvm-commits mailing list