[PATCH] D154854: Use empty symbol name for XCOFF text csect

[David Tenty via Phabricator via llvm-commits]

daltenty accepted this revision.
daltenty added a comment.

LGTM with some minor nits



================
Comment at: llvm/test/CodeGen/PowerPC/aix-text-ref.ll:6-8
+source_filename = "te.c"
+target datalayout = "E-m:a-p:32:32-Fi32-i64:64-n32"
+target triple = "powerpc-ibm-aix7.2.0.0"
----------------
nit: you can remove all this metadata, since it doesn't affect the test. The defaults will be supplied by your llc invocation.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-text-ref.ll:20-24
+!llvm.module.flags = !{!1}
+!llvm.ident = !{!3}
+
+!1 = !{i32 8, !"PIC Level", i32 2}
+!3 = !{!""}
----------------
nit: ditto the earlier comment, you can strip all this metadata out to simplify the test


================
Comment at: llvm/test/CodeGen/PowerPC/aix-text.ll:10
+
+source_filename = "text.c"
+target datalayout = "E-m:a-p:32:32-Fi32-i64:64-n32"
----------------
nit: ditto the metadata comments about the other test file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154854/new/

https://reviews.llvm.org/D154854