[PATCH] D150388: [CodeGen]Allow targets to use target specific COPY instructions for live range splitting

Fri Jul 14 09:43:00 PDT 2023

arsenm added a comment.

In D150388#4501339 <https://reviews.llvm.org/D150388#4501339>, @asmok-g wrote:

> Headsup: This change might be causing a miscompile. We're having some breakages in google because of this change that goes away when we add `__attribute__((optnone)) ` to https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Tooling/Transformer/SourceCode.h#L111. I'm working on confirming it.

The easiest experiment would be to change the implementation of isCopyInstr to not bother calling isCopyInstrImpl. The most likely source of any issue is the broader recognition of copy-like operations

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150388/new/

https://reviews.llvm.org/D150388