[PATCH] D155305: AMDGPU: Mark control flow pseudos as convergent

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 08:53:49 PDT 2023


arsenm created this revision.
arsenm added reviewers: AMDGPU, foad, sameerds, rampitec, critson.
Herald added subscribers: StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

https://reviews.llvm.org/D155305

Files:
  llvm/lib/Target/AMDGPU/SIInstructions.td


Index: llvm/lib/Target/AMDGPU/SIInstructions.td
===================================================================
--- llvm/lib/Target/AMDGPU/SIInstructions.td
+++ llvm/lib/Target/AMDGPU/SIInstructions.td
@@ -418,6 +418,7 @@
   let Size = 12;
   let hasSideEffects = 1;
   let IsNeverUniform = 1;
+  let isConvergent = 1;
 }
 
 def SI_ELSE : CFPseudoInstSI <
@@ -426,6 +427,7 @@
   let Size = 12;
   let hasSideEffects = 1;
   let IsNeverUniform = 1;
+  let isConvergent = 1;
 }
 
 def SI_WATERFALL_LOOP : CFPseudoInstSI <
@@ -434,6 +436,7 @@
   let Size = 8;
   let isBranch = 1;
   let Defs = [];
+  let isConvergent = 1;
 }
 
 def SI_LOOP : CFPseudoInstSI <
@@ -443,6 +446,7 @@
   let isBranch = 1;
   let hasSideEffects = 1;
   let IsNeverUniform = 1;
+  let isConvergent = 1;
 }
 
 } // End isTerminator = 1
@@ -453,6 +457,7 @@
   let isAsCheapAsAMove = 1;
   let isReMaterializable = 1;
   let hasSideEffects = 1;
+  let isConvergent = 1;
   let isNotDuplicable = 1; // Not a hard requirement, see long comments above for details.
   let mayLoad = 1; // FIXME: Should not need memory flags
   let mayStore = 1;
@@ -464,6 +469,7 @@
   let isNotDuplicable = 1; // Not a hard requirement, see long comments above for details.
   let isAsCheapAsAMove = 1;
   let isReMaterializable = 1;
+  let isConvergent = 1;
 }
 
 // Branch to the early termination block of the shader if SCC is 0.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155305.540439.patch
Type: text/x-patch
Size: 1389 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230714/e78939f5/attachment.bin>


More information about the llvm-commits mailing list