[PATCH] D154465: [PowerPC] Add DFP format instructions definitions and MC tests

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 06:54:49 PDT 2023


stefanp accepted this revision.
stefanp added a comment.

I only have one minor nit.
Otherwise, LGTM!

Feel free to address the nit when you commit the patch.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrDFP.td:115
+defm DIEXQ: XForm_base_r3xo_r<63, 866, (outs fpairrc:$RST),
+                              (ins fpairrc:$RA, fpairrc:$RB),
+                              "diexq", "$RST, $RA, $RB", []>;
----------------
nit:
Should be `f8rc:$RA`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154465/new/

https://reviews.llvm.org/D154465



More information about the llvm-commits mailing list